This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add digest
and downloadLocation
to VSA policy
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjoelkamp
force-pushed
the
feat-generate-vsa-policy-uri
branch
5 times, most recently
from
August 14, 2024 15:47
31747e3
to
21d6402
Compare
mrjoelkamp
force-pushed
the
feat-generate-vsa-policy-uri
branch
from
August 14, 2024 15:57
21d6402
to
d2a8348
Compare
mrjoelkamp
force-pushed
the
feat-generate-vsa-policy-uri
branch
2 times, most recently
from
August 14, 2024 17:40
7dcb935
to
e9890f5
Compare
mrjoelkamp
changed the title
feat: generate VSA policy value from file
feat: add Aug 14, 2024
digest
and downloadLocation
to VSA policy field
mrjoelkamp
force-pushed
the
feat-generate-vsa-policy-uri
branch
from
August 14, 2024 17:52
e9890f5
to
2bf7dec
Compare
mrjoelkamp
changed the title
feat: add
feat: add Aug 14, 2024
digest
and downloadLocation
to VSA policy fielddigest
and downloadLocation
to VSA policy
whalelines
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions
Co-authored-by: David Dooling <[email protected]>
mrjoelkamp
force-pushed
the
feat-generate-vsa-policy-uri
branch
from
August 14, 2024 20:01
57da04f
to
cb47507
Compare
whalelines
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more question came to mind
whalelines
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vsa.policy.digest
vsa.policy.downloadLocation
vsa.policy.uri
optional (based on whether it is set or not by the Rego result summary)Testing
Example VSA using HTTP policy source (without
policy.uri
set in Rego)Example VSA using OCI policy source (without
policy.uri
set in Rego)