Skip to content

Commit

Permalink
lint: add nolintlint and fix violations
Browse files Browse the repository at this point in the history
We should be able to detect nolint comments that point to linters that
are disabled (such as with the removed structcheck).

Signed-off-by: Justin Chadwell <[email protected]>
  • Loading branch information
jedevc committed Oct 20, 2022
1 parent 4e22846 commit a4c3efe
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ linters:
- revive
- staticcheck
- typecheck
- nolintlint
disable-all: true

linters-settings:
Expand Down
3 changes: 0 additions & 3 deletions commands/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,7 @@ type commonOptions struct {
progress string
pull *bool

// golangci-lint#826
// nolint:structcheck
exportPush bool
// nolint:structcheck
exportLoad bool
}

Expand Down

0 comments on commit a4c3efe

Please sign in to comment.