Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update to docker v28.0.0 #3014

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

crazy-max
Copy link
Member

closes #3009

Also adds alt for previous Docker 27 release.

@thaJeztah
Copy link
Member

Also adds alt for previous Docker 27 release.

Ah, thanks! I was looking at that a few times, and I gathered we wanted to keep v26.1 in there at least because that's still the one used in GitHub actions, but adding an extra one probably makes sense.

Would it make sense to handle this through a table in GitHub actions (instead of continuing to add more to the Dockefile?)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max
Copy link
Member Author

I gathered we wanted to keep v26.1 in there at least because that's still the one used in GitHub actions, but adding an extra one probably makes sense.

Yes I kept 26 specially for GHA 👍

@crazy-max crazy-max merged commit 221a608 into docker:master Feb 20, 2025
131 checks passed
@crazy-max crazy-max deleted the dockerfile-docker-28 branch February 20, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants