-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official shellcheck image #1538
Use official shellcheck image #1538
Conversation
This PR is built on top of #1537, so marking it WIP; only the last commit is new. ping @vdemeester @albers PTAL |
For reference; these are the failures when using the
|
0077c51
to
a6dbbf9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 56.12% 56.12%
=======================================
Files 306 306
Lines 21030 21030
=======================================
Hits 11803 11803
Misses 8373 8373
Partials 854 854 |
a6dbbf9
to
4cf7785
Compare
hm.. forgot that circleci still expects Trying to find why it passed for me yesterday, but fails now 🤔 |
Ah; must've tried with |
Right, and I see all the failures are due to three new checks that were added in shellcheck v0.4.7;
I'll update the PR to use |
0bfe2bd
to
9896b9d
Compare
9896b9d
to
4f8115a
Compare
4026a9e
to
2cdf492
Compare
2cdf492
to
40fa43c
Compare
This patch switches the shellcheck image to use the official image from Docker Hub. Note that this does not yet update shellcheck to the latest version (v0.5.x); Shellcheck v0.4.7 added some new checks, which makes CI currently fail, so will be done in a follow-up PR. Instead, the v0.4.6 version is used in this PR, which is closest to the same version as was installed in the image before this change; ``` docker run --rm docker-cli-shell-validate shellcheck --version ShellCheck - shell script analysis tool version: 0.4.4 license: GNU General Public License, version 3 website: http://www.shellcheck.net ``` Signed-off-by: Sebastiaan van Stijn <[email protected]>
40fa43c
to
388646e
Compare
This patch switches the shellcheck image to use the official image from Docker Hub.
Note that this does not yet update shellcheck to the latest version (v0.5.x); Shellcheck v0.4.7 added some new checks, which makes CI currently fail, so will be done in a follow-up PR. Instead, the v0.4.6 version is used in this PR, which is closest to the same version as was installed in the image before this change;