Forcing the creation of tmp directory #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "master" [email protected]:arthrp/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
- Coverage 56.75% 56.75% -0.01%
==========================================
Files 309 309
Lines 21672 21658 -14
==========================================
- Hits 12301 12292 -9
+ Misses 8472 8469 -3
+ Partials 899 897 -2 |
|
@arthrp could you sign-off and amend your commit? |
… it already exists Signed-off-by: Arthur Peka <[email protected]>
|
@thaJeztah no problem, hope it's good now. |
thaJeztah
added
platform/windows
status/2-code-review
and removed
status/0-triage
labels
|
SGTM (i'm not john hodgman) |
|
Anything more to be done from my side? |
|
Looks like this one dropped off the radar; still LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently make.ps1 fails when 'tmp' directory already exists (e.g. due to the failed build).
You get error such as:
Passing -Force flag fixes that.