Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gometalinter: raise deadline to 3 minutes #2172

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

thaJeztah
Copy link
Member

Looks like we're just on the edge of the deadline, and it's sometimes
failing;

cli/command/image/trust.go:346:1:warning: nolint directive did not match any issue (nolint)
cli/command/manifest/push.go:211:1:warning: nolint directive did not match any issue (nolint)
internal/pkg/containerized/snapshot.go:95:1:warning: nolint directive did not match any issue (nolint)
internal/pkg/containerized/snapshot.go:138:1:warning: nolint directive did not match any issue (nolint)
WARNING: deadline exceeded by linter interfacer (try increasing --deadline)
Exited with code 3

Looks like we're just on the edge of the deadline, and it's sometimes
failing;

```
cli/command/image/trust.go:346:1:warning: nolint directive did not match any issue (nolint)
cli/command/manifest/push.go:211:1:warning: nolint directive did not match any issue (nolint)
internal/pkg/containerized/snapshot.go:95:1:warning: nolint directive did not match any issue (nolint)
internal/pkg/containerized/snapshot.go:138:1:warning: nolint directive did not match any issue (nolint)
WARNING: deadline exceeded by linter interfacer (try increasing --deadline)
Exited with code 3
```

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 48f2426 into docker:master Oct 29, 2019
@thaJeztah thaJeztah deleted the gometalinter_deadline branch October 29, 2019 14:54
@thaJeztah thaJeztah added this to the next milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants