expose config credentials without needing the Cli #227
Conversation
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 46.85% 46.98% +0.13%
==========================================
Files 172 172
Lines 11692 11693 +1
==========================================
+ Hits 5478 5494 +16
+ Misses 5902 5882 -20
- Partials 312 317 +5 |
cli/config/config.go
Outdated
| func LoadDefaultConfigFile(err io.Writer) *configfile.ConfigFile { | ||
| configFile, e := Load(Dir()) | ||
| if e != nil { | ||
| fmt.Fprintf(err, "WARNING: Error loading config file:%v\n", e) |
There was a problem hiding this comment.
I realize this code is only moved, but it looks like a space is missing between : and %v.
|
Fixed the string format and added a couple more unit tests. |
cli/config/configfile/file.go
Outdated
| @@ -53,6 +53,15 @@ type ProxyConfig struct { | |||
| FTPProxy string `json:"ftpProxy,omitempty"` | |||
| } | |||
|
|
|||
| // NewConfigFile initializes an empty configuration file for the given filename 'fn' | |||
| func NewConfigFile(fn string) *ConfigFile { | |||
There was a problem hiding this comment.
nit: maybe in the context of this pkg it should just be called New
|
Given that @dnephin is on PTO this week, perhaps someone can carry those nits? |
|
I'll carry this one 😉 |
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
vdemeester
force-pushed
the
expose-config
branch
2 times, most recently
from
379623e to
fda6366
Compare
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
expose-config
branch
from
fda6366 to
105b21d
Compare
| expected := types.AuthConfig{ | ||
| Username: "foo", | ||
| Password: "bar", | ||
| Email: "[email protected]", |
There was a problem hiding this comment.
Do we still have to test for the Email field here?
There was a problem hiding this comment.
Maybe not but could be handled in a follow-up 👼
There was a problem hiding this comment.
If the credential helper stores email, I think we should still test for it.
|
@vdemeester thanks for making that |
Related to moby/moby#30817
Move
GetAllCredentials(), andCredentialsStore()from theDockerClito theConfigFilestruct, so that are easier to use externally.