Remove duplicate logouts with private registry with unit tests. #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "master-duplicate-cred-erase" [email protected]:jrpalma/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: jrpalma <[email protected]>
jrpalma
force-pushed
the
master-duplicate-cred-erase
branch
from
2f53441 to
98b7215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed the problem of docker logout trying to erase credentials multiple times, which leads to an warning when credentials no longer exist. This happened with docker-credentials-pass on Linux on Ubuntu 18.04. Fixes #204
- How I did it
I did not add the registry to be loged out if it is a private registry. Hence, removing the duplicate entry.
- How to verify it
I created unit test to ensure the credential is not erased twice.
- Description for the changelog
Do not erase private registry credential multiple times.