Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker context to zsh completion #2906

Merged

Conversation

stoffus
Copy link
Contributor

@stoffus stoffus commented Jan 4, 2021

- What I did

Added zsh completion for the docker context subcommands.

- How I did it

Followed the convention of the other completions.

- How to verify it

  1. Replace the content of the current _docker plugin (most likely located in ~/.oh-my-zsh/plugins/docker/_docker for Oh My Zsh users).
  2. If not already present, append the docker plugin in your .zshrc, e.g. plugins=(git mvn docker).
  3. Reload zsh with source ~/.zshrc.
  4. The plugin should now include the new context subcommands, e.g. docker context use <tab>.

- Description for the changelog
Added zsh completion for docker context subcommands.

- A picture of a cute animal (not mandatory but encouraged)

uggla-2

@stoffus stoffus force-pushed the added-docker-context-to-zsh-completion branch from fb412ec to b04241d Compare January 5, 2021 07:29
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #2906 (b04241d) into master (2291f61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2906   +/-   ##
=======================================
  Coverage   57.05%   57.05%           
=======================================
  Files         297      297           
  Lines       18653    18653           
=======================================
  Hits        10643    10643           
  Misses       7151     7151           
  Partials      859      859           

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stoffus 👍 I works well on my zsh 🚀

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants