scripts/docs/generate-md.sh: fix location of generate code #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1e3622c moved the generator code to a subdirectory, but forgot to update the markdown version of this script. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This adds the new aliases that were added in 9b54d86 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
kind/docs
status/2-code-review
process/cherry-pick
kind/bugfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
+ Coverage 58.66% 59.03% +0.37%
==========================================
Files 286 288 +2
Lines 24769 24776 +7
==========================================
+ Hits 14531 14627 +96
+ Misses 9355 9265 -90
- Partials 883 884 +1 |
|
@crazy-max @dvdksn ptal |
crazy-max
approved these changes
Apr 9, 2023
|
We should also look at validation of markdown to avoid drifting in the future, see PR description in #3924 (comment)
|
|
Yes we should validate this as part of CI; I thought we already did, but indeed it was not yet done (also see #4166 (comment)) I created #4171 for tracking Let me bring this one in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
docker container removeas an alias #3986scripts/docs/generate-md.sh: fix location of generate code
Commit 1e3622c (#3991) moved the generator code
to a subdirectory, but forgot to update the markdown version of this script.
docs: regenerate markdown docs
This adds the new aliases that were added in 9b54d86 (#3986)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)