docs: update link targets #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdksn
force-pushed
the
docs-cli-reference-urlscheme
branch
from
ec5c8e2 to
98492a6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4866 +/- ##
=======================================
Coverage 61.32% 61.32%
=======================================
Files 287 287
Lines 20063 20063
=======================================
Hits 12303 12303
Misses 6867 6867
Partials 893 893 |
dvdksn
force-pushed
the
docs-cli-reference-urlscheme
branch
from
98492a6 to
379b93a
Compare
thaJeztah
requested changes
Feb 9, 2024
dvdksn
force-pushed
the
docs-cli-reference-urlscheme
branch
from
379b93a to
4fc5b65
Compare
dvdksn
changed the title
dvdksn
force-pushed
the
docs-cli-reference-urlscheme
branch
4 times, most recently
from
6a67639 to
175799c
Compare
dvdksn
changed the title
|
not sure what the failing tests are here but probably not related? @thaJeztah |
|
Re-ran the tests ✅ |
|
@thaJeztah can you TAL since you left some comments? |
|
Weird failures, can you rebase @dvdksn? |
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
docs-cli-reference-urlscheme
branch
from
175799c to
08b2e13
Compare
|
@laurazard rebased, looks OK now |
thaJeztah
reviewed
Feb 20, 2024
thaJeztah
reviewed
Feb 20, 2024
| The following example example inspects the `tiborvass/sample-volume-plugin` plugin: | ||
| The following example inspects the `tiborvass/sample-volume-plugin` plugin: |
There was a problem hiding this comment.
Hm... we need to enable the "dupwords" linter. But perhaps it only checks Go code, and not markdown files 🤔
thaJeztah
reviewed
Feb 20, 2024
thaJeztah
reviewed
Feb 20, 2024
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
docs-cli-reference-urlscheme
branch
from
08b2e13 to
caf7265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Moving the files to a different URL scheme on docs.docker.com breaks some of the links in this repository. docker/docs#19370
I've updated the affected links, and also patched the yaml generation in
cli-docs-toolto handle the URL path discrepancy that now exists between this repository and the website. docker/cli-docs-tool#49- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)