-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loader error with different build syntax #544
Conversation
`build: .` was not working anymore. Fixing this by adding a new tranform function for BuildConfig. Signed-off-by: Vincent Demeester <[email protected]>
7646849
to
0da9f14
Compare
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 49.06% 49.07% +<.01%
==========================================
Files 200 200
Lines 16438 16447 +9
==========================================
+ Hits 8066 8072 +6
- Misses 7952 7955 +3
Partials 420 420 |
Do we know where it broke, and if this needs to be back ported? |
@thaJeztah from #481. As we don't load it anyway in |
@vdemeester kinda odd since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cdrage it's just that your PR didn't take into account
|
@vdemeester Doh. I forgot about that too. Thanks for the fix 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build: .
was not working anymore. Fixing this by adding a newtranform function for BuildConfig.
/cc @cdrage
Signed-off-by: Vincent Demeester [email protected]