Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dns_opt in version 3 #5010

Closed
ylavoie opened this issue Jul 9, 2017 · 9 comments
Closed

Implement dns_opt in version 3 #5010

ylavoie opened this issue Jul 9, 2017 · 9 comments

Comments

@ylavoie
Copy link

ylavoie commented Jul 9, 2017

Even with version 3, dns_opt is still required to pass specific options like ndots and get around dns problems

@shin-
Copy link

shin- commented Jul 13, 2017

Please submit v3 feature requests on the docker/cli repo.

@shin- shin- closed this as completed Jul 13, 2017
@maciejmatuszak
Copy link

Hi @shin- the docker cli already implements the --dns-opt or --dns-option. The docker-compose dns-opt is in V2 https://docs.docker.com/compose/compose-file/compose-file-v2/#dns_opt but is not V3. What would it take to implement/port it from V2 to V3?

@shin-
Copy link

shin- commented Nov 27, 2018

The v3 format is controlled and updated on the docker/cli repo (as the primary intention of the v3 format is to work with docker stack deploy), so it needs to be proposed there first before we can port the change back into the docker-compose codebase. For the change to be accepted in docker/cli, it would probably require an implementation of the feature for Swarm services (which seems to exist at the API level, so shouldn't be too daunting to add).

@ps-jay
Copy link

ps-jay commented Dec 10, 2018

Hi @shin-,

I'm trying to understand what you mean by the "v3 format is controlled and updated on the docker/cli repo".

What file(s), should I look at in docker/cli to see what is (or should be) supported by compose?

From what I can see, --dns-option is already in the docker run CLI (see: docker/cli@ebacbb5), but it's not available in compose.

Should we raise an issue in docker/cli that dns_option is not also available in the v3 format?

@shin-
Copy link

shin- commented Dec 10, 2018

Hi @shin-,

I'm trying to understand what you mean by the "v3 format is controlled and updated on the docker/cli repo".

What file(s), should I look at in docker/cli to see what is (or should be) supported by compose?

https://github.com/docker/cli/tree/master/cli/compose/schema/data

From what I can see, --dns-option is already in the docker run CLI (see: docker/cli@ebacbb5), but it's not available in compose.

Should we raise an issue in docker/cli that dns_option is not also available in the v3 format?

Yes.

@ps-jay
Copy link

ps-jay commented Dec 10, 2018

Thanks @shin-,
I've opened an issue in docker/cli.

@phyrwork
Copy link

phyrwork commented Sep 2, 2021

Looks like this has been implemented since 1.27.0

@ilayarajamurugesan-alation

Looks like this has been implemented since 1.27.0

@phyrwork Don't think this is related to the docker-compose version. The compose file version 3 still doesn't support dns_opt: https://docs.docker.com/compose/compose-file/compose-file-v3/

@phyrwork
Copy link

phyrwork commented Sep 2, 2021

Well docker-compose 1.27+ with schema 3.9+ can certainly inject dns_opt 🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants