enable support for dns_opt
in compose again
#6680
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in docker-compose v3 the dns_opt option was not enabled in the config_schema. The option however is correctly passed to the Docker CLI. A test even still exists for this, see
tests/integration/service_test.py
test_dns_opt_value
.This PR enables the dns_opt again. The schema is a copy from v3.7 with the addition of dns_opt on line 133.
Tested against Docker version 18.09.1, build 4c52b90.
Resolves