Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement service profiles in Compose #7919

Closed
chris-crone opened this issue Nov 10, 2020 · 4 comments · Fixed by #7930
Closed

Implement service profiles in Compose #7919

chris-crone opened this issue Nov 10, 2020 · 4 comments · Fixed by #7930
Labels
kind/feature

Comments

@chris-crone
Copy link
Member

Now that service profiles are part of the Compose spec, we should implement them here.
@mkalam-alami mkalam-alami mentioned this issue Nov 13, 2020
Closed
acran added a commit to acran/compose that referenced this issue Nov 15, 2020
@acran
Implement service profiles
df59ff8 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539
acran added a commit to acran/compose that referenced this issue Nov 15, 2020
@acran
Implement service profiles
01e01d9 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539

Signed-off-by: Roman Anasal <[email protected]>
@acran acran mentioned this issue Nov 15, 2020
Merged
acran added a commit to acran/compose that referenced this issue Nov 16, 2020
@acran
Implement service profiles
e02bba4 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539

Signed-off-by: Roman Anasal <[email protected]>
acran added a commit to acran/compose that referenced this issue Nov 30, 2020
@acran
Implement service profiles
bc2e56f 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539

Signed-off-by: Roman Anasal <[email protected]>
acran added a commit to acran/compose that referenced this issue Dec 1, 2020
@acran
Implement service profiles
e2b323c 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539

Signed-off-by: Roman Anasal <[email protected]>
acran added a commit to acran/compose that referenced this issue Dec 1, 2020
@acran
Implement service profiles
a5e5318 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539

Signed-off-by: Roman Anasal <[email protected]>
acran added a commit to acran/compose that referenced this issue Dec 2, 2020
@acran
Implement service profiles
2d2a8a0 
Implement profiles as introduced in compose-spec/compose-spec#110
fixes docker#7919
closes docker#1896
closes docker#6742
closes docker#7539

Signed-off-by: Roman Anasal <[email protected]>
@tablatronix
Copy link

Are there docker specific docs for this, or should we just reference compose-spec ?

@chris-crone
Copy link
Member Author

At the moment I think we only have the spec that describes this. We do need docs so I'll add that to our backlog. Thanks for calling this out @tablatronix !

@acran
Copy link

acran commented Jan 21, 2021 •
edited
Loading

@tablatronix @chris-crone in docker/docs#11844 I already created a draft to add this with some examples to the docker-compose docs, waiting for feedback.

A preview can currently be found at https://deploy-preview-11844--docsdocker.netlify.app/compose/profiles/

@chris-crone
Copy link
Member Author

@acran Thanks, not sure how I missed that. I gave it a quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement service profiles acran/compose
3 participants
@tablatronix @chris-crone @acran