Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge: testing update deps #11273

Closed
wants to merge 3 commits into from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 13, 2023

vendor: update cli to prevent go1.16 language downgrade

full diff: thaJeztah/cli@7b3a60f...70216b6

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

dependabot bot and others added 2 commits December 14, 2023 14:33
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    64.86 pkg/compose/watch.go:431:48: batch[i].HostPath undefined (type fileEvent has no field or method HostPath) (typecheck)
    64.86 				strings.Join(append([]string{""}, batch[i].HostPath), "\n  - "),
    64.86 				                                           ^
    64.86 pkg/compose/kill_test.go:119:2: composefile declared and not used (typecheck)
    64.86 	composefile := filepath.Join(workingdir, "compose.yaml")
    64.86 	^
    64.86 pkg/e2e/ps_test.go:87:6: missing type in composite literal (typecheck)
    64.86 					{
    64.86 					^

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the test_update_docker branch 3 times, most recently from 975e2fe to ea325f3 Compare December 14, 2023 14:05
@thaJeztah
Copy link
Member Author

IT WORKS!!!

@milas
Copy link
Contributor

milas commented Jan 4, 2024

@milas milas closed this Jan 4, 2024
@thaJeztah thaJeztah deleted the test_update_docker branch January 4, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants