manage watch applied to mulitple services
#12469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
multi-service-watch
branch
7 times, most recently
from
45f3ec1 to
c95b804
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
multi-service-watch
branch
2 times, most recently
from
8dced24 to
063889a
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
multi-service-watch
branch
from
063889a to
571c6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
watchused to be ran per service which brings race condition when a file event has impacts on multiple services.This PR changes the implementation so we collect file events, then check all services for watch rules matching update, and eventually apply required actions.
Updated logic is :
watcherfor the paths declared by all services in projectRelated issue
closes #12427
(not mandatory) A picture of a cute animal, if possible in relation to what you did
