-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fig build
logging
#3
Conversation
Bollocks, thank you. I should write a test or something. |
FWIW, I have no idea what I'm doing. |
Yeah it's #2. So basically fig doesn't remove containers unless you explicitly ask it to, because they might have something you care about on them. But then when you run What we should probably do is |
The current conservative behaviour seems sensible, but yeah, even a friendly warning would've helped me to understand where the problem might be. |
It's complicated balance with speed as well – ideally we'd rebuild your images every time, but Docker doesn't cache the right things to let us do that yet. Should be in 0.7.3 though, so by then we shouldn't have to do this. |
Fix `fig build` logging Signed-off-by: Yuval Kohavi <[email protected]>
The logger wasn't available, and the log message was unfinished.