Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fig build logging #3

Merged
merged 2 commits into from
Jan 2, 2014
Merged

Fix fig build logging #3

merged 2 commits into from
Jan 2, 2014

Conversation

tomstuart
Copy link

The logger wasn't available, and the log message was unfinished.

bfirsh added a commit that referenced this pull request Jan 2, 2014
@bfirsh bfirsh merged commit 9ede185 into docker:master Jan 2, 2014
@bfirsh
Copy link

bfirsh commented Jan 2, 2014

Bollocks, thank you. I should write a test or something.

@tomstuart
Copy link
Author

FWIW, fig build didn't seem to do everything I needed: I'd cocked up my fig.yml or my Dockerfile or something (exposed the wrong port), but even after fixing the file and running fig build, the problem persisted and I had to fig rm the containers and start again. (I guess this is what #2 is about.)

I have no idea what I'm doing.

@bfirsh
Copy link

bfirsh commented Jan 2, 2014

Yeah it's #2. So basically fig doesn't remove containers unless you explicitly ask it to, because they might have something you care about on them. But then when you run fig up, it starts any containers that have been stopped because that probably what you normally want to do.

What we should probably do is fig up should do something clever if it looks like you've changed something ("hey! looks like you've done something, shall I rebuild the image and recreate the containers for you?"). We'll have a think about that tomorrow.

@tomstuart
Copy link
Author

The current conservative behaviour seems sensible, but yeah, even a friendly warning would've helped me to understand where the problem might be.

@bfirsh
Copy link

bfirsh commented Jan 2, 2014

It's complicated balance with speed as well – ideally we'd rebuild your images every time, but Docker doesn't cache the right things to let us do that yet. Should be in 0.7.3 though, so by then we shouldn't have to do this.

@tomstuart tomstuart deleted the fix-fig-build-logging branch January 3, 2014 10:58
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Fix `fig build` logging
Signed-off-by: Yuval Kohavi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants