Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name support '-' and '_' #572

Closed
wants to merge 1 commit into from

Conversation

tsaikd
Copy link

@tsaikd tsaikd commented Oct 22, 2014

Any reason to disable '-' and '_' for project name?

@aanand
Copy link

aanand commented Oct 22, 2014

Yes - we keep track of services and what containers are running in them by naming containers <project>_<service>_<number> (in the absence of any other way of storing metadata on containers), so allowing underscores in the project name will confuse that.

As for hyphens, it's mostly an aesthetic thing - mixing hyphens and underscores is a bit icky.

@bfirsh
Copy link

bfirsh commented Oct 22, 2014

Plus we want to switch to using them as the separator: #229

@tsaikd I'm afraid this time again we can't accept your contribution. Thanks for the help though!

@bfirsh bfirsh closed this Oct 22, 2014
@tsaikd tsaikd deleted the more-valid-project-name branch October 23, 2014 03:51
@ghost
Copy link

ghost commented Oct 17, 2017

This is not a reason to disable dashes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants