Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAR-274] bump to golang 1.10.6 #281

Merged
merged 1 commit into from
Dec 14, 2018
Merged

[TAR-274] bump to golang 1.10.6 #281

merged 1 commit into from
Dec 14, 2018

Conversation

seemethere
Copy link
Contributor

Signed-off-by: Eli Uriegas [email protected]

@seemethere
bump to golang 1.10.6
010a8c2 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere seemethere requested review from andrewhsu, thaJeztah and a team December 13, 2018 23:47
@seemethere seemethere changed the title bump to golang 1.10.6 TAR-274 bump to golang 1.10.6 Dec 13, 2018
@seemethere seemethere changed the title TAR-274 bump to golang 1.10.6 [TAR-274] bump to golang 1.10.6 Dec 13, 2018
@seemethere seemethere mentioned this pull request Dec 13, 2018
Merged
thaJeztah
thaJeztah approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@seemethere if we're gonna use "master" to build "nightly", we'll have to do a follow-up to bump to Go 1.11. I'll prepare a PR

@thaJeztah thaJeztah mentioned this pull request Dec 14, 2018
Merged
@thaJeztah
Copy link
Member

Follow up PR: #283

corbin-coleman
corbin-coleman approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@corbin-coleman corbin-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewhsu
andrewhsu approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@docker-unir docker-unir bot merged commit 4612932 into docker:master Dec 14, 2018
@seemethere seemethere deleted the 1_10_6 branch December 17, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbin-coleman corbin-coleman corbin-coleman approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@andrewhsu andrewhsu andrewhsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seemethere @thaJeztah @andrewhsu @corbin-coleman