Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Golang images to debian stretch variant #369

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

thaJeztah
Copy link
Member

the default switched to debian buster, which will have side-effects (e.g. libgcc-6-dev is no longer in buster)

@thaJeztah
Copy link
Member Author

ping @seemethere @kolyshkin PTAL

@thaJeztah thaJeztah mentioned this pull request Aug 6, 2019
4 tasks
@thaJeztah
Copy link
Member Author

Actually; not sure if we need this, because we only copy the Go binaries 🤔

@thaJeztah
Copy link
Member Author

oh, never mind; we do use the golang image for the image variant;

FROM ${GO_IMAGE} as builder
COPY hack/dockerfile/install/tini.installer /
COPY hack/dockerfile/install/proxy.installer /
RUN apt-get update && apt-get install -y \
bash \
btrfs-tools \
ca-certificates \
cmake \
gcc \
git \
libc-dev \
libgcc-6-dev \

Verified

This commit was signed with the committer’s verified signature.
mikz Michal Cichra
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fine intermediary step but we should work to get back on the latest versions of these images eventually

@seemethere seemethere merged commit aab70be into docker:master Aug 6, 2019
@thaJeztah thaJeztah deleted the pin_to_stretch branch August 6, 2019 22:18
@thaJeztah
Copy link
Member Author

yeah, there's more side effects to switching to buster; see moby/moby#39549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants