[master] bump compose version to v2.17.2 #866

thaJeztah · 2023-03-27T07:59:56Z

https://github.com/docker/compose/releases/tag/v2.17.2

https://github.com/docker/compose/releases/tag/v2.17.2 Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah · 2023-03-27T08:44:40Z

Hmm... panic during build?

docker buildx inspect | grep -q 'Driver: docker-container' || docker buildx create --use
boring_cohen
cd /home/ubuntu/workspace/docker-ce-packaging_PR-866/src/github.com/docker/cli && VERSION=0.0.0-20230326145633-59ec357 docker buildx bake --set binary.platform=darwin/amd64,darwin/arm64 binary
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x840767]

goroutine 1 [running]:
github.com/docker/buildx/bake/hclparser.(*parser).resolveValue(0xc0000a94a0, {0xc0002f4cf0, 0xa})
	/src/bake/hclparser/hclparser.go:244 +0xe27
github.com/docker/buildx/bake/hclparser.Parse({0x23087f8, 0xc00030e030}, {0x20ccb18?, 0xc000263710?, 0x20c95e0?}, {0x1e0ccc0?, 0xc000263740})
	/src/bake/hclparser/hclparser.go:358 +0xbcd
github.com/docker/buildx/bake.ParseFiles({0xc0003b02d0, 0x1, 0x19?}, 0x18?)
	/src/bake/bake.go:238 +0xa45
github.com/docker/buildx/bake.ReadTargets({0x13?, 0x0?}, {0xc0003b02d0?, 0xc00005e004?, 0x4b?}, {0xc000508ea0, 0x1, 0xc0005ff801?}, {0xc0001bb1e0, 0x1, ...}, ...)
	/src/bake/bake.go:88 +0x52
github.com/docker/buildx/commands.runBake({0x2318158, 0xc0003e02a0}, {0xc000508ea0, 0x1, 0x3}, {{0x329a860, 0x0, 0x0}, {0xc0001bb1e0, 0x1, ...}, ...})
	/src/commands/bake.go:106 +0xb2c
github.com/docker/buildx/commands.bakeCmd.func1(0xc0001c1680?, {0xc000508ea0, 0x1, 0x3})
	/src/commands/bake.go:182 +0x205
github.com/spf13/cobra.(*Command).execute(0xc0001c1680, {0xc0004905c0, 0x3, 0x3})
	/src/vendor/github.com/spf13/cobra/command.go:872 +0x694
github.com/spf13/cobra.(*Command).ExecuteC(0xc000005b80)
	/src/vendor/github.com/spf13/cobra/command.go:990 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
	/src/vendor/github.com/spf13/cobra/command.go:918
github.com/docker/cli/cli-plugins/plugin.RunPlugin(0x1cacc60?, 0xc0001c1180, {{0x1fa6529, 0x5}, {0x1fb06f1, 0xb}, {0x22e4060, 0x7}, {0x0, 0x0}, ...})
	/src/vendor/github.com/docker/cli/cli-plugins/plugin/plugin.go:51 +0x130
main.runPlugin(0x1fe97e8?)
	/src/cmd/buildx/main.go:45 +0x105
main.main()
	/src/cmd/buildx/main.go:62 +0xf9
make[1]: *** [Makefile:74: cross-mac] Error 2
make[1]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-866/static'
make: *** [Makefile:97: static] Error 2
script returned exit code 2

/cc @crazy-max

thaJeztah · 2023-03-27T08:46:40Z

23.0 backport is happy though; [23.0 backport] bump compose version to v2.17.2 #867

thaJeztah · 2023-03-27T08:47:30Z

Could this be because of docker/cli#4117 ?

thaJeztah · 2023-03-27T09:04:08Z

Unable to reproduce on my machine 🤔 tried buildx 0.10.3 and 0.10.4;

 VERSION=0.0.0-20230326145633-59ec357 docker buildx bake --set binary.platform=darwin/amd64,darwin/arm64 binary
[+] Building 20.1s (28/28) FINISHED
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                   0.0s
 => => transferring dockerfile: 5.48kB                                                                                                                                                                                                                 0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                      0.0s
 => => transferring context: 263B                                                                                                                                                                                                                      0.0s
 => resolve image config for docker.io/docker/dockerfile:1                                                                                                                                                                                             4.2s
 => CACHED docker-image://docker.io/docker/dockerfile:1@sha256:39b85bbfa7536a5feceb7372a0817649ecb2724562a38360f4d6a7782a409b14                                                                                                                        0.0s
 => => resolve docker.io/docker/dockerfile:1@sha256:39b85bbfa7536a5feceb7372a0817649ecb2724562a38360f4d6a7782a409b14                                                                                                                                   0.0s
 => [linux/arm64/v8 internal] load metadata for docker.io/tonistiigi/xx:1.1.1                                                                                                                                                                          3.2s
 => [linux/arm64/v8 internal] load metadata for docker.io/library/golang:1.19.7-alpine3.16                                                                                                                                                             4.4s
 => [darwin/amd64 internal] load metadata for docker.io/dockercore/golang-cross:xx-sdk-extras                                                                                                                                                          6.4s
 => [darwin/arm64 internal] load metadata for docker.io/dockercore/golang-cross:xx-sdk-extras                                                                                                                                                          6.4s
 => [internal] load build context                                                                                                                                                                                                                      0.3s
 => => transferring context: 1.35MB                                                                                                                                                                                                                    0.3s
 => [linux/arm64/v8 build-base-alpine 1/4] FROM docker.io/library/golang:1.19.7-alpine3.16@sha256:dc189dcfcea54267261d8b93d59d1041ab6a076d7a3e7a30c498055d3f660260                                                                                     0.0s
 => => resolve docker.io/library/golang:1.19.7-alpine3.16@sha256:dc189dcfcea54267261d8b93d59d1041ab6a076d7a3e7a30c498055d3f660260                                                                                                                      0.0s
 => CACHED FROM docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41                                                                                                                0.0s
 => => resolve docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41                                                                                                                 0.0s
 => [linux/arm64/v8 xx 1/1] FROM docker.io/tonistiigi/xx:1.1.1@sha256:23ca08d120366b31d1d7fad29283181f063b0b43879e1f93c045ca5b548868e9                                                                                                                 0.0s
 => => resolve docker.io/tonistiigi/xx:1.1.1@sha256:23ca08d120366b31d1d7fad29283181f063b0b43879e1f93c045ca5b548868e9                                                                                                                                   0.0s
 => CACHED FROM docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41                                                                                                                0.0s
 => => resolve docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41                                                                                                                 0.0s
 => CACHED [linux/arm64/v8 build-base-alpine 2/4] COPY --from=xx / /                                                                                                                                                                                   0.0s
 => CACHED [linux/arm64 build-base-alpine 3/4] RUN apk add --no-cache bash clang lld llvm file git                                                                                                                                                     0.0s
 => CACHED [linux/arm64/v8 build-base-alpine 4/4] WORKDIR /go/src/github.com/docker/cli                                                                                                                                                                0.0s
 => CACHED [linux/arm64->darwin/amd64 build-alpine 1/1] RUN xx-apk add --no-cache musl-dev gcc                                                                                                                                                         0.0s
 => CACHED [linux/arm64 goversioninfo 1/1] RUN --mount=type=cache,target=/root/.cache/go-build     --mount=type=cache,target=/go/pkg/mod     GOBIN=/out GO111MODULE=on go install "github.com/josephspurrier/goversioninfo/cmd/[email protected]"   0.0s
 => CACHED [linux/arm64/v8->darwin/amd64 build 1/3] COPY --from=goversioninfo /out/goversioninfo /usr/bin/goversioninfo                                                                                                                                0.0s
 => CACHED [linux/arm64->darwin/amd64 build 2/3] RUN [ ! -f /etc/alpine-release ] && xx-info is-cross && [ "$(xx-info arch)" = "arm64" ] && XX_CC_PREFER_LINKER=ld xx-clang --setup-target-triple || true                                              0.0s
 => CACHED [linux/arm64->darwin/arm64 build-alpine 1/1] RUN xx-apk add --no-cache musl-dev gcc                                                                                                                                                         0.0s
 => CACHED [linux/arm64/v8->darwin/arm64 build 1/3] COPY --from=goversioninfo /out/goversioninfo /usr/bin/goversioninfo                                                                                                                                0.0s
 => CACHED [linux/arm64->darwin/arm64 build 2/3] RUN [ ! -f /etc/alpine-release ] && xx-info is-cross && [ "$(xx-info arch)" = "arm64" ] && XX_CC_PREFER_LINKER=ld xx-clang --setup-target-triple || true                                              0.0s
 => [linux/arm64->darwin/arm64 build 3/3] RUN --mount=type=bind,target=.,ro     --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresourc  7.9s
 => [linux/arm64->darwin/amd64 build 3/3] RUN --mount=type=bind,target=.,ro     --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresourc  7.3s
 => [darwin/amd64 binary 1/1] COPY --from=build /out .                                                                                                                                                                                                 0.0s
 => [darwin/arm64 binary 1/1] COPY --from=build /out .                                                                                                                                                                                                 0.0s
 => exporting to client                                                                                                                                                                                                                                0.6s
 => => copying files darwin/amd64 36.86MB                                                                                                                                                                                                              0.6s
 => => copying files darwin/arm64 35.07MB

git log
commit 59ec357996ec467275adfd87a9f52a8f543fb291 (HEAD -> master, upstream/master, upstream/HEAD, origin/master, origin/HEAD, build_0.10.4)
Merge: f5d698a33 b854eff30
Author: Sebastiaan van Stijn <[email protected]>
Date:   Sun Mar 26 16:56:33 2023 +0200

    Merge pull request #4117 from crazy-max/align-go-ver

    Dockerfile: align go version

thaJeztah · 2023-03-27T09:18:51Z

Oh! Looks like it's for the static builds only (not sure I checked that).

Wondering what version of buildx is running on these machines though;

  buildx: Docker Buildx (Docker Inc.)
    Version:  c5aec24
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx

docker version
Client: Docker Engine - Community
 Version:           22.06.0-beta.0
 API version:       1.42
 Go version:        go1.18.3
 Git commit:        3e9117b
 Built:             Fri Jun  3 17:55:45 2022
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          22.06.0-beta.0
  API version:      1.42 (minimum version 1.12)
  Go version:       go1.18.3
  Git commit:       38633e7
  Built:            Fri Jun  3 17:55:45 2022
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          1.6.8
  GitCommit:        9cd3357b7fd7218e4aec3eae239db1f68a5a6ec6
 runc:
  Version:          1.1.4
  GitCommit:        v1.1.4-0-g5fd4c4d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info
Client:
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  c5aec24
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.12.0
    Path:     /usr/libexec/docker/cli-plugins/docker-compose
  scan: Docker Scan (Docker Inc.)
    Version:  v0.17.0
    Path:     /usr/libexec/docker/cli-plugins/docker-scan

Server:
 Containers: 0
  Running: 0
  Paused: 0
  Stopped: 0
 Images: 1
 Server Version: 22.06.0-beta.0
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 9cd3357b7fd7218e4aec3eae239db1f68a5a6ec6
 runc version: v1.1.4-0-g5fd4c4d
 init version: de40ad0
 Security Options:
  apparmor
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 5.15.0-1022-aws
 Operating System: Ubuntu 20.04.5 LTS
 OSType: linux
 Architecture: x86_64
 CPUs: 2
 Total Memory: 7.475GiB
 Name: ip-10-100-116-126
 ID: c944a62a-a99e-4e56-b148-df1906108e3b
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Username: dockerbuildbot
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: true
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: true

thaJeztah · 2023-03-27T09:19:45Z

Looks like a pre-0.10.0; docker/buildx@c5aec24

crazy-max · 2023-03-27T10:01:11Z

Ah damn yeah looks to be a pre 0.10 😣

thaJeztah · 2023-03-27T10:09:08Z

discussed with @crazy-max

we'll temporarily revert the null values in the bake-file in docker/cli
look at updating the CI machines to have a proper 23.0.x install (plus updated buildx)

thaJeztah · 2023-03-27T15:05:04Z

Looks like we need to update the setup-buildx-action in this repo (looks like it's still on v1);

docker/setup-buildx-action@v1

At least I think that's what producing these warnings;

github.com/docker/buildx 0.10.4+azure-1 c513d34049e499c53468deac6c4267ee72948f02
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

thaJeztah · 2023-03-27T15:14:59Z

All green now 👍

bump compose version to v2.17.2

5e20a7d

https://github.com/docker/compose/releases/tag/v2.17.2 Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah requested review from milas and glours March 27, 2023 08:00

glours approved these changes Mar 27, 2023

View reviewed changes

thaJeztah mentioned this pull request Mar 27, 2023

[23.0 backport] bump compose version to v2.17.2 #867

Merged

rumpl approved these changes Mar 27, 2023

View reviewed changes

crazy-max mentioned this pull request Mar 27, 2023

don't use null values in the bake definition docker/cli#4122

Merged

thaJeztah closed this Mar 27, 2023

thaJeztah reopened this Mar 27, 2023

thaJeztah merged commit 0d574bf into docker:master Mar 27, 2023

thaJeztah deleted the compose_2.17.2 branch March 27, 2023 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[master] bump compose version to v2.17.2 #866

[master] bump compose version to v2.17.2 #866

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

crazy-max commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

[master] bump compose version to v2.17.2 #866

[master] bump compose version to v2.17.2 #866

Conversation

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

crazy-max commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023

thaJeztah commented Mar 27, 2023