Simplify .NET multi-platform Dockerfile #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
changed the title
richlander
reviewed
Jul 14, 2023
richlander
reviewed
Jul 14, 2023
|
Wow! Somehow missed this PR, so apologies on the slow response. Thanks for the update and for sharing the new capabilities. Super cool! We'll go ahead and merge this in. Thanks again! |
GhenaCadin
pushed a commit
to Pokfinner/example-voting-app
that referenced
this pull request
Jan 4, 2025
* Improve dotnet multiplatform dockerfile * Use implicit TARGETPLATFORM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since .NET 7.0.300, the new
-a/--archargument is supported that accepts the same formatting as Docker's $TARGETARCH. This greatly simplifies the restore and build commands in this sample.See @richlander's blog post and dotnet/sdk#30369 for more context.