Update 'required' rule to prohibit blank spaces #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 'required' rule, updated this: this.helpers.isBlank(val) to a regex that makes sure the value is NOT a blank space(tab, space, etc): this.helpers.testRegex(val, /[^\s]/)
|
@gcatala-cr seems like the implementation of the |
|
Yea, that makes sense. |
|
Added in latest release: https://github.com/dockwa/simple-react-validator/releases/tag/1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
On a required field, entering ONLY a space(space or tab) is accepted as a valid value.
On our end we had to override the required rule with a regex test to prohibit lone spaces from passing validation.
Replicated on multiple browsers.
Tested on Google Chrome Version 74.0.3729.169 (Official Build) (64-bit)
Mac OS Mojave Version 10.14.5 (18F132)
Bug is reproducible on working example from Git page:
https://dockwa.github.io/simple-react-validator/index.html
Update:
On 'required' rule, updated this:
this.helpers.isBlank(val)
to a regex that makes sure the value is NOT a blank space(tab, space, etc):
this.helpers.testRegex(val, /[^\s]/)