Test suite changes

[mohammedsahl]

Summary
This PR aims to duplicate the current sidebar e2e tests for the desktop over to mobile. In addition there is a small test for #1243

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

Integration tests added. Complete overhaul of cypress/snapshots/sidebar snapshots.

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)

• Electron 78 (headless)

Other information:
Adding describe or context or it changes the filename of the snapshot. This causes test to fail.
In order to use describe and context, I had to delete all existing snapshots and re-run npm run test:e2e.

I verified if the new snapshots generated were correct through manual inspection. In addition I carried out a second verification by running npm run test:e2e twice in a row, ensuring all tests pass.

I expect some of the e2e tests checks to fail for this PR

---

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/bv5aecgyt
✅ Preview: https://docsify-preview-git-fork-mlh-fellowship-test-suite-changes.docsify-core.vercel.app

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 79ff495:

Sandbox	Source
hardcore-forest-cyvq0	Configuration

[anikethsaha]

One question , did you move the tests to mobile cases or keeping both ?

[mohammedsahl]

One question , did you move the tests to mobile cases or keeping both ?

Keeping both. I simply copied the same tests (with a few minor changes) over to mobile. Mobile is the equvalient of adding

cy.viewport('iphone-x`)
cy.visit('localhost:3000`)

to beforeEach

[mohammedsahl]

Please see #1254 (comment)

[anikethsaha]

I am seeing some removal of code from the old tests. Can you give me some details about that ?

thanks

[mohammedsahl]

I am seeing some removal of code from the old tests. Can you give me some details about that ?

thanks

Sure, no worries! Its mainly because I've wrapped the entire test in a describe code block. I was thinking it makes it easier to organize tests that would be added in the future. If you notice, the code that is removed is exactly the same as what was added.

For example:
This was removed and this was added
Note you will need to click on "Load diff" to look at the code since the diff is pretty large

[trusktr]

It's not as big a deal for test code, but I would prefer to avoid duplicate code if possible, having both mobile and desktop tests import from a shared file.

[mohammedsahl]

Gonna close this PR for now. I'll have a look again once again in the near future (~1 week)

[trusktr]

@mohammedsahl Another thing you can do instead of closing is leaving it open but mark it as a "draft" PR in the right sidebar. Looks like this:

Also when making a new PR it gives you the option to create it up front as a "draft" PR.

Sorry for lag on my end, It's tax time and have been working on business stuff related to that.