Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctrine/persistence v3 is not allowed #2450

Closed
garak opened this issue May 1, 2022 · 4 comments · Fixed by #2454
Closed

doctrine/persistence v3 is not allowed #2450

garak opened this issue May 1, 2022 · 4 comments · Fixed by #2454

Comments

@garak
Copy link

garak commented May 1, 2022

This repository is restricting doctrine/persistence to version 2.
Unless some changes introduced in v3 are blocking, the new version should be allowed as well.

@mbabker
Copy link
Contributor

mbabker commented May 2, 2022

#2448 points out one blocker. It looks like #2373 gave a way to fix it in downstream applications (and stof/StofDoctrineExtensionsBundle#436 exists to help users of that Symfony bundle apply it), but the two places still calling that deprecated Doctrine\Persistence\Mapping\AbstractMetadata::getCacheDriver() method still need some kind of conditional logic to not fail hard with 3.0 installed.

It looks like https://github.com/doctrine/persistence/blob/3.0.x/UPGRADE.md#bc-break-removed-lifecycleeventargsgetentity could potentially be an issue, hard to say on a quick scan though because of how much dynamic code is involved in pushing the event args object through to the adapters.

Off hand, I don't know if there's anything in this package supporting short namespace aliases, but that's gone too - https://github.com/doctrine/persistence/blob/3.0.x/UPGRADE.md#bc-break-removed-support-for-short-namespace-aliases

@Romaixn
Copy link

Romaixn commented May 9, 2022

+1 It would be very cool if V3 was supported for the package to work under Symfony 6 🎉

@mbabker
Copy link
Contributor

mbabker commented May 9, 2022

+1 It would be very cool if V3 was supported for the package to work under Symfony 6

This package will work fine with Symfony 6 (all the Symfony components that integrate with Doctrine support 2.x or 3.x for the Persistence package). You'll need to ensure doctrine/persistence is locked to the 2.x branch in your application until #2454 is merged and a new release is published.

@franmomu
Copy link
Collaborator

I would be nice if people could try it before making a release using the main branch in their projects:

"gedmo/doctrine-extensions": "dev-main"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants