Allow to set a cache to store configuration #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2373 +/- ##
============================================
+ Coverage 80.91% 81.00% +0.08%
- Complexity 3150 3152 +2
============================================
Files 159 159
Lines 8149 8160 +11
============================================
+ Hits 6594 6610 +16
+ Misses 1555 1550 -5
Continue to review full report at Codecov.
|
mbabker
reviewed
Dec 12, 2021
| // Cache the result, even if it's empty, to prevent re-parsing non-existent annotations. | ||
| $cacheId = self::getCacheId($className, $this->extensionNamespace); | ||
|
|
||
| if (null === $this->cachePoolItem) { |
There was a problem hiding this comment.
Move this up? No point in computing a cache ID if the cache pool isn't set.
There was a problem hiding this comment.
thanks! in a previous version I was setting the configuration to the metadata cache when $this->cachePoolItem was null I forgot to move it again.
phansys
added
Needs Changelog note
Bug
franmomu
force-pushed
the
use_cache
branch
2 times, most recently
from
474ca92 to
72b1e69
Compare
franmomu
changed the title
phansys
approved these changes
Dec 31, 2021
franmomu
force-pushed
the
use_cache
branch
2 times, most recently
from
7e70827 to
4039035
Compare
|
Thanks @franmomu! |
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2365, #2227
Instead of relying on the metadata cache from the orm/odm, this PR adds a
MappedEventSubscriber::setCacheItemPool()method to configure the cache service, in case it is not provided it uses anArrayAdapter(this will invalidate existing caches).For the bundle, a service can be created (allowing users to configure their own) and call
setCacheItemPoolin every definition assetAnnotationReader(https://github.com/stof/StofDoctrineExtensionsBundle/blob/a2bffca41974d1c968557b343e269a60a8d5ffa4/src/Resources/config/blameable.xml#L13-L15)AbstractClassMetadataFactory::getCacheDriver()that we have to figure out what to do(Make users add mapping to tree closure entities #2390).