Merge pull request #1286 from doctrine/deprecate-blacklist

#1176 Deprecate (Blacklist|WellKnown) schema filters
doctrine · Feb 11, 2021 · cf98a24 · cf98a24
2 parents 91f0139 + 6cb9e25
commit cf98a24
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 0 deletions.
diff --git a/Dbal/BlacklistSchemaAssetFilter.php b/Dbal/BlacklistSchemaAssetFilter.php
@@ -6,6 +6,9 @@
 
 use function in_array;
 
+/**
+ * @deprecated Implement your own include/exclude mechanism
+ */
 class BlacklistSchemaAssetFilter
 {
     /** @var string[] */

diff --git a/DependencyInjection/Compiler/WellKnownSchemaFilterPass.php b/DependencyInjection/Compiler/WellKnownSchemaFilterPass.php
@@ -12,6 +12,8 @@
 
 /**
  * Blacklist tables used by well-known Symfony classes.
+ *
+ * @deprecated Implement your own include/exclude mechanism
  */
 class WellKnownSchemaFilterPass implements CompilerPassInterface
 {

diff --git a/Tests/DependencyInjection/AbstractDoctrineExtensionTest.php b/Tests/DependencyInjection/AbstractDoctrineExtensionTest.php
@@ -889,6 +889,7 @@ public static function dataWellKnownSchemaFilterServices()
 
     /**
      * @dataProvider dataWellKnownSchemaFilterServices
+     * @group legacy
      */
     public function testWellKnownSchemaFilterDefaultTables(string $fileName, string $tableName): void
     {
@@ -927,6 +928,7 @@ public static function dataWellKnownSchemaOverriddenTablesFilterServices()
 
     /**
      * @dataProvider dataWellKnownSchemaOverriddenTablesFilterServices
+     * @group legacy
      */
     public function testWellKnownSchemaFilterOverriddenTables(string $fileName, string $tableName): void
     {

diff --git a/UPGRADE-2.3.md b/UPGRADE-2.3.md
@@ -0,0 +1,8 @@
+UPGRADE FROM 2.2 to 2.3
+=======================
+
+DependencyInjection
+--------
+
+ * `\Doctrine\Bundle\DoctrineBundle\Dbal\BlacklistSchemaAssetFilter` has been deprecated. Implement your own include/exclude strategies.
+ * `\Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\WellKnownSchemaFilterPass` has been deprecated. Implement your own include/exclude strategies.
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,8 @@ @@
     /**
      * Blacklist tables used by well-known Symfony classes.
+     *
+     * @deprecated Implement your own include/exclude mechanism
      */
     class WellKnownSchemaFilterPass implements CompilerPassInterface
     {
@@ Expand Down @@