Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messenger table not yet filtered out by WellKnownSchemaFilterPass #1061

Closed
weaverryan opened this issue Nov 21, 2019 · 4 comments
Closed

Messenger table not yet filtered out by WellKnownSchemaFilterPass #1061

weaverryan opened this issue Nov 21, 2019 · 4 comments

Comments

@weaverryan
Copy link
Contributor

From #1037, the WellKnownSchemaFilterPass works overall, but the Messenger part was flawed. There is no Connection service that is added when the Doctrine transport is active. Instead, (check FrameworkExtension), for each transport, a factory is used to create the transport. It's quite dynamic, unfortunately (to support env vars), which makes it impossible to see at container build time which type of transport it will use.

I'm not sure of a good solution - I'm hoping @nicolas-grekas might have an idea!

@ostrolucky
Copy link
Member

Indeed, this needs concrete proposal in order to make this actionable. Might require changes on symfony side.

@stale
Copy link

stale bot commented Dec 20, 2019

This issue is still waiting on feedback. Please provide the information requested above to allow us to continue working on this ticket.
This issue will be closed after 7 days. You can still provide us with the necessary information to continue working on this issue, and we will reopen the ticket for you. Thanks!

@stale stale bot added the Stale label Dec 20, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 20, 2019

@nicolas-grekas do you have an idea on how to solve this?

@stale stale bot removed the Stale label Dec 20, 2019
@stale
Copy link

stale bot commented Jan 3, 2020

This issue is still waiting on feedback. Please provide the information requested above to allow us to continue working on this ticket.
This issue will be closed after 7 days. You can still provide us with the necessary information to continue working on this issue, and we will reopen the ticket for you. Thanks!

@stale stale bot added the Stale label Jan 3, 2020
@stale stale bot closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants