Filter out well-known Symfony tables from DBAL schema migrations #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a closing comment to your original message, I think it's related :) |
nicolas-grekas
force-pushed
the
auto-ignore-sf-tables
branch
from
c282981 to
a7afd13
Compare
greg0ire
reviewed
Oct 21, 2019
nicolas-grekas
force-pushed
the
auto-ignore-sf-tables
branch
from
a7afd13 to
8c1c435
Compare
nicolas-grekas
force-pushed
the
auto-ignore-sf-tables
branch
from
8c1c435 to
e4ca3d2
Compare
|
I like this, as it hopefully solves a lot of problems for people. Only question I have: would it make sense to require DBAL 2.9? It has been out for almost a year, so I'd hope most people are already running it. We can bump in a separate PR, just thinking that we might as well bump here as this wouldn't work when running anything older than 2.9. WDYT @nicolas-grekas? |
alcaeus
approved these changes
Oct 23, 2019
|
Thanks @nicolas-grekas! We'll bump doctrine/dbal in a separate PR for 2.0 only. |
|
Thanks @alcaeus! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents constantly generating
DROP TABLE sessions, etc. when generating migrations.Closes #987