default_entity_manager config param is not inherited from parent config file

[bravik]

This line in Configuratation:

DoctrineBundle/DependencyInjection/Configuration.php

Line 376 in 09339f7

$v['default_entity_manager'] = isset($v['default_entity_manager']) ? (string) $v['default_entity_manager'] : 'default';

makes default_entity_manager (=<some_none_default_value>) param defined in config/packages/doctrine.yml
been overriden by config/packages/prod/doctrine.yml without this option.
Instead of the value from config/packages/doctirne.yml we have default value.
Which is conter-intuitive and took a couple of time to investigate mapping issues.

Example:

#c onfig/packages/doctrine.yml
doctrine:
  # ...
    orm:
        auto_generate_proxy_classes: true
        default_entity_manager: app
        entity_managers:
            app:
               # ...
            module:
               #...

#config/packages/prod/doctrine.yml
# The default one, generated by flex

doctrine:
    orm:
        auto_generate_proxy_classes: false
        metadata_cache_driver:
            type: pool
            pool: doctrine.system_cache_pool
        query_cache_driver:
            type: pool
            pool: doctrine.system_cache_pool
        result_cache_driver:
            type: pool
            pool: doctrine.result_cache_pool

Expected: app
Given: default

[ostrolucky]

Can be also tested via bin/console debug:container --parameter=doctrine.default_entity_manager --env=prod and bin/console debug:container --parameter=doctrine.default_entity_manager --env=dev, respectively.

If anyone want to work on this, I think solution would be to extract this normalization

DoctrineBundle/DependencyInjection/Configuration.php

Lines 376 to 377 in d6b3c37

	$v['default_entity_manager'] = isset($v['default_entity_manager']) ? (string) $v['default_entity_manager'] : 'default';
	$v['entity_managers'] = [$v['default_entity_manager'] => $entityManager];

to DoctrineExtension

[ostrolucky]

Patch has been merged into 2.4. It should prevent similar issues in future