Fix configuration inheritance to not override default connection/EM values #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucksaun
force-pushed
the
fix-configuration-inheritance
branch
from
34af8c5 to
d6dc672
Compare
ostrolucky
requested changes
Apr 14, 2023
tucksaun
force-pushed
the
fix-configuration-inheritance
branch
2 times, most recently
from
a07c83d to
18874e1
Compare
Yeah, I've read that 😞 |
…nection and default_entity_manager This another take at fixing 1337 but also at dbal section that has the same issue with `default_connection`
tucksaun
force-pushed
the
fix-configuration-inheritance
branch
from
18874e1 to
17bc9a3
Compare
|
@ostrolucky thank you for the review btw! |
|
could we do the checks on default connection and default entity manager together at the beginning, to process the configuration only twice instead of 3 times ? Otherwise, we might report deprecations 3 times when a deprecated setting is used. |
|
Good call @stof ! |
|
Good idea I think |
tucksaun
force-pushed
the
fix-configuration-inheritance
branch
from
85f44de to
f071a0a
Compare
ostrolucky
reviewed
Apr 19, 2023
ostrolucky
approved these changes
Apr 19, 2023
dmaicher
approved these changes
Apr 21, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I recently unveiled a weird behavior when doing some cleanup on a project I work on.
Long story short, we have several connections, use a different name than
defaultfor the main one, and because we have config files defining onlydoctrine.dbal.types, thedefault_connectionends up being reset todefault.While trying to fix this I realized this is similar to #1337 (just another section of the config really), so I try to fix #1337 at the same time (therefore being an alternative to #1356).
The true nature of the fix is mostly not to run the custom pre-normalization process but then this makes the default empty configuration not work anymore.
So we move the side effect of this process (creating an empty 'default' connection configuration) out in the Extension and we rerun the normalization process again so that the default values for connections and entity manager get resolved properly.
This should be considered a bugfix, but I'm not really sure which branch to target in that case, let me know if you want me to rebase and target another branch instead