Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require php-7.4-friendly version of Twig #1025

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Require php-7.4-friendly version of Twig #1025

merged 2 commits into from
Oct 8, 2019

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 6, 2019 •
edited
Loading

@greg0ire greg0ire mentioned this pull request Oct 6, 2019
Merged
@greg0ire
Copy link
Member Author

greg0ire commented Oct 6, 2019

The build fails because of a new deprecation in sf 4.4 . I'm adding a second commit that should fix it.

@greg0ire greg0ire requested a review from a team October 6, 2019 15:59
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 7, 2019 •
edited
Loading

could be inside the try?
GenerateEntitiesDoctrineCommand also needs it, isn't it?

@greg0ire
Ensure execute always returns an integer
741ac22 
This is mandatory since Symfony 4.4
@greg0ire greg0ire force-pushed the ensure-compatibility-with-7.4 branch from 70ed682 to 741ac22 Compare October 7, 2019 13:21
@greg0ire
Copy link
Member Author

greg0ire commented Oct 7, 2019

@nicolas-grekas done and done :)

@greg0ire greg0ire mentioned this pull request Oct 7, 2019
Merged
derrabus
derrabus reviewed Oct 8, 2019
View reviewed changes
@alcaeus
Copy link
Member

alcaeus commented Oct 8, 2019

Thanks @greg0ire!

@alcaeus alcaeus merged commit 4def364 into doctrine:1.12.x Oct 8, 2019
@alcaeus alcaeus added this to the 1.12.0 milestone Oct 8, 2019
@greg0ire greg0ire deleted the ensure-compatibility-with-7.4 branch October 8, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
1.12.0-Beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@greg0ire @nicolas-grekas @alcaeus @fabpot @derrabus