Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiler explain error in SQLServerPlatform, OtherPlatform #1267

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fix profiler explain error in SQLServerPlatform, OtherPlatform #1267

merged 1 commit into from
Nov 25, 2020

Conversation

RealJTG
Copy link
Contributor

@RealJTG RealJTG commented Nov 25, 2020 •
edited by stof
Loading

Fix #1266

@ostrolucky
Copy link
Member

ostrolucky commented Nov 25, 2020 •
edited
Loading

Please fix the CS and rebase on 2.2

@ostrolucky ostrolucky changed the base branch from master to 2.2.x November 25, 2020 16:28
@ostrolucky ostrolucky added this to the 2.2.2 milestone Nov 25, 2020
@RealJTG RealJTG force-pushed the bug/1266_profiler_explain_error branch 2 times, most recently from b961786 to 3ad6822 Compare November 25, 2020 16:47
@stof stof changed the title Fix #1266 profiler explain error in SQLServerPlatform, OtherPlatform Fix profiler explain error in SQLServerPlatform, OtherPlatform Nov 25, 2020
@stof
Copy link
Member

stof commented Nov 25, 2020

This Autowire entity managers by argument type and name commit in the PR looks wrong. This seems to indicate a messed-up rebase

@RealJTG RealJTG force-pushed the bug/1266_profiler_explain_error branch from 3ad6822 to 6d20de0 Compare November 25, 2020 16:52
@RealJTG
Copy link
Contributor Author

RealJTG commented Nov 25, 2020

@stof my bad, sorry :)

@ostrolucky ostrolucky merged commit 3187d59 into doctrine:2.2.x Nov 25, 2020
@ostrolucky ostrolucky mentioned this pull request Nov 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@ostrolucky ostrolucky ostrolucky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@RealJTG @ostrolucky @stof