deprecate sharding functionality #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
deprecated_shards
branch
from
060afe7 to
7d339bc
Compare
dmaicher
force-pushed
the
deprecated_shards
branch
2 times, most recently
from
99963d6 to
c8b7fcb
Compare
dmaicher
force-pushed
the
deprecated_shards
branch
from
c8b7fcb to
522cec3
Compare
|
What's our plan for dropping support for Doctrine DBAL v2? We could probably do it for 2.8 then? So people still get a chance to see the deprecations triggered here and can upgrade accordingly? |
ostrolucky
approved these changes
Apr 15, 2022
|
If we are going to remove these options, we have to do it in 3.0 |
yeah although this cannot work with DBAL 3 I guess it could still be considered a BC break to remove those options. Let's do it on 3.0 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1467