[DoctrineBundle] feat: doctrine schema subscribers as listeners #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alli83
force-pushed
the
doctrine-bundle-shema-subscribers-as-listeners
branch
from
b27ef61 to
e7e4a48
Compare
|
It seems the dependencies installed for psalm check are Symfony 5.4. It could explained why the class psalm.xml.dist updated in order to suppress error |
alli83
force-pushed
the
doctrine-bundle-shema-subscribers-as-listeners
branch
from
e7e4a48 to
8a6c21f
Compare
nicolas-grekas
approved these changes
Mar 10, 2023
ostrolucky
requested changes
Mar 11, 2023
alli83
force-pushed
the
doctrine-bundle-shema-subscribers-as-listeners
branch
2 times, most recently
from
4409509 to
15c5c1c
Compare
|
updated |
| @@ -394,18 +397,28 @@ protected function ormLoad(array $config, ContainerBuilder $container) | |||
| $container->removeAlias('doctrine.orm.metadata.annotation_reader'); | |||
| } | |||
|
|
|||
| // available in Symfony 6.3 | |||
| class_exists(DoctrineDbalCacheAdapterSchemaListener::class) ? | |||
There was a problem hiding this comment.
$container->removeDefinition('doctrine.orm.listeners.doctrine_dbal_cache_adapter_schema_' . (class_exists(DoctrineDbalCacheAdapterSchemaListener::class) ? 'listener' : 'subscriber));
and let's do this also for pre-existing lines below
There was a problem hiding this comment.
ok ! if I'm not mistaken, there is just the case for the 3 new listeners. I'll double check
alli83
force-pushed
the
doctrine-bundle-shema-subscribers-as-listeners
branch
from
15c5c1c to
db7a166
Compare
alli83
force-pushed
the
doctrine-bundle-shema-subscribers-as-listeners
branch
from
db7a166 to
c435315
Compare
nicolas-grekas
approved these changes
Mar 12, 2023
ostrolucky
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to PR symfony/symfony#49610
Doctrine schema listeners are deprecated and changed as listeners