Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpspec/prophecy is now explicitely needed for tests #401

Closed
DavidPrevot opened this issue Aug 28, 2022 · 0 comments · Fixed by #402
Closed

phpspec/prophecy is now explicitely needed for tests #401

DavidPrevot opened this issue Aug 28, 2022 · 0 comments · Fixed by #402

Comments

@DavidPrevot
Copy link

Hi,

Since PHPUnit dropped phpspec/prophecy from its dependencies (sebastianbergmann/phpunit#5033), the following error is triggered when running the testsuite with latest PHPUnit.

There was 1 error:

1) Doctrine\Tests\Common\DataFixtures\ReferenceRepositoryTest::testGetIdentifierWhenHasNotBeenManagedYetByUnitOfWork
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".

Regards

David
greg0ire added a commit to greg0ire/data-fixtures that referenced this issue Aug 28, 2022
@greg0ire
Avoid prophecy
439bf4b 
It is no longer bundled by default in PHPUnit, which causes a build
failure. Rather than requiring the missing package, migrating to PHPUnit
mocks should result in code easier to analyse by SA tools.

Fixes doctrine#401
@greg0ire greg0ire mentioned this issue Aug 28, 2022
Merged
greg0ire added a commit to greg0ire/data-fixtures that referenced this issue Aug 28, 2022
@greg0ire
Avoid prophecy
42ea3c8 
It is no longer bundled by default in PHPUnit, which causes a build
failure. Rather than requiring the missing package, migrating to PHPUnit
mocks should result in code easier to analyse by SA tools.

Fixes doctrine#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid prophecy greg0ire/data-fixtures
1 participant
@DavidPrevot