Merge pull request #4123 from morozov/remove-error-suppressions

Remove the no longer needed error suppressions
doctrine · Jun 28, 2020 · 831e6fe · 831e6fe
2 parents 8bdb609 + 2136c9a
commit 831e6fe
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -105,11 +105,6 @@
         <exclude-pattern>lib/Doctrine/DBAL/Driver/ExceptionConverterDriver.php</exclude-pattern>
     </rule>
 
-    <!-- See https://github.com/slevomat/coding-standard/issues/1038 -->
-    <rule ref="SlevomatCodingStandard.Namespaces.UnusedUses">
-        <exclude-pattern>tests/Doctrine/Tests/DBAL/Functional/Driver/IBMDB2/StatementTest.php</exclude-pattern>
-    </rule>
-
     <!-- see https://github.com/doctrine/dbal/issues/3377 -->
     <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators.DisallowedNotEqualOperator">
         <exclude-pattern>lib/Doctrine/DBAL/Schema/Comparator.php</exclude-pattern>

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -23,11 +23,6 @@ parameters:
         - '~^Property Doctrine\\DBAL\\Schema\\Schema::\$_schemaConfig \(Doctrine\\DBAL\\Schema\\SchemaConfig\) does not accept default value of type false\.\z~'
         - '~^Return type \(int\|false\) of method Doctrine\\DBAL\\Driver\\OCI8\\OCI8Connection\:\:lastInsertId\(\) should be compatible with return type \(string\) of method Doctrine\\DBAL\\Driver\\Connection::lastInsertId\(\)~'
 
-        # https://github.com/phpstan/phpstan/issues/3527
-        -
-            message: '~^Call to private method sqliteCreateFunction\(\) of parent class PDO\.$~'
-            path: %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php
-
         # https://github.com/phpstan/phpstan/issues/2857
         # TODO: remove in 4.0.0
         - '~^Parameter #2 \$registeredAliases of static method Doctrine\\DBAL\\Query\\QueryException::nonUniqueAlias\(\) expects array<string>, array<int, int\|string> given\.\z~'