getShardManager function not defined

[duhruh]

The comments for doctrine/dbal:PoolingShardConnection indicate that we are able to run the function getShardManager on the returned connection. However this will not work since for whatever reason the function PoolingShardConnection::getShardManager wasn't carried over from doctrine/shards:PoolingShardConnection. Was this intended, or are we responsible for bringing in the sharding library. If we are responsible then i'm not sure why a copy of this exists in it's own repository and in this one.

Edit: okay it looks like getShardManager was intentionally removed in this commit b6f48e1 so can the documentation be updated as to the recommend way to get the shard manager and select a shard.

Edit: Okay i didn't feel like waiting 😝 I'm assuming this is the recommended way to handle this now

        $chooser = new MultiTenantShardChoser();
        $conn = DriverManager::getConnection([
                'wrapperClass' => 'Doctrine\DBAL\Sharding\PoolingShardConnection', 'driver' => 'pdo_mysql',
                'global' =>['user' => '', 'password' => '', 'host' => '', 'dbname' => ''],
                'shards' => [
                    ['id' => 1, 'user' => 'slave1', 'password', 'host' => '', 'dbname' => ''],
                    ['id' => 2, 'user' => 'slave2', 'password', 'host' => '', 'dbname' => ''],
                ],
                'shardChoser' => $chooser,
            ]);

        $shardManager = new PoolingShardManager($conn, $chooser);
        $shardManager->selectGlobal();
        $shardManager->selectShard(1);

if so can you update the docs for other poor helpless souls out there struggling with this like me 😄

last thing if you do update these docs can you guys please update the word shardChoser in the code, chooser is spelt with 2 O's i.e. shardChooser

last last thing i also just noticed that there's no reason for shardChoser to even be passed into PoolingShardConnection as it doesn't reference this at all, unless there's something i'm missing. Since you guys took out getShardManager i think that was the only reference to the shard choser, so since you removed one of them, shouldn't you remove both?

[lorenzleutgeb]

I just came across the same issue(s). I am happy to provide a PR that fixes documentation and stays backward compatible with 2.5.

@Ocramius would you be willing to receive such a PR?

[Ocramius]

Patch ahead 👍

…

On 24 Aug 2017 10:06 PM, "Lorenz Leutgeb" ***@***.***> wrote: I just came across the same issue(s). I am happy to provide a PR that fixes documentation and stays backward compatible with 2.5. @Ocramius <https://github.com/ocramius> would you be willing to receive such a PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2371 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakCCkhM_1bYDKYIZtvC3KhLEnIepeks5sbde4gaJpZM4IM2BL> .

[morozov]

Closing as no longer supported (#3602).

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.