Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequence::isAutoIncrementsFor() is not normalising PK column, and is unable to distinguish different casing #2714

Closed
dhensby opened this issue May 5, 2017 · 1 comment
Closed

Sequence::isAutoIncrementsFor() is not normalising PK column, and is unable to distinguish different casing #2714

dhensby opened this issue May 5, 2017 · 1 comment
Assignees
@deeky666
Labels
Bug Fixed Schema Definition Schema Introspection Sequences
Milestone
2.5.13

Comments

@dhensby
Copy link
Contributor

dhensby commented May 5, 2017

The Sequence::isAutoIncrementsFor() method is not normalising the PK column when computing the $tableSequenceName for comparison. This means primary keys with uppercase characters in them are not correctly compared and incorrectly return false. This results in Schema migration SQL incorrectly attempting to drop sequences.

I'll look to submit a patch for this.

Experienced on: Postgres 9.2, Centos 7, dbal 2.5.12, PHP 5.6
@dhensby dhensby mentioned this issue May 5, 2017
Merged
@deeky666 deeky666 self-assigned this May 10, 2017
@deeky666 deeky666 added this to the 2.5.13 milestone May 10, 2017
@Ocramius Ocramius changed the title Sequence::isAutoIncrementsFor() not normalising PK column Sequence::isAutoIncrementsFor() is not normalising PK column Jul 22, 2017
@Ocramius Ocramius changed the title Sequence::isAutoIncrementsFor() is not normalising PK column Sequence::isAutoIncrementsFor() is not normalising PK column, and is unable to distinguish different casing Jul 22, 2017
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deeky666 deeky666

Labels
Bug Fixed Schema Definition Schema Introspection Sequences
Projects
None yet
Milestone
2.5.13
Development

No branches or pull requests
3 participants
@Ocramius @dhensby @deeky666