Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2714 Sequence::isAutoIncrementsFor() is now case-insensitive #2715

Merged
merged 2 commits into from
May 10, 2017
Merged

#2714 Sequence::isAutoIncrementsFor() is now case-insensitive #2715

merged 2 commits into from
May 10, 2017

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented May 5, 2017

Fixes #2714

@Ocramius
Copy link
Member

Ocramius commented May 8, 2017

@dhensby please re-target this patch to 2.5 - we will backport afterwards if worth doing so.

@dhensby
Copy link
Contributor Author

dhensby commented May 8, 2017

@Ocramius It is targeted at 2.5 :)

@Ocramius
Copy link
Member

Ocramius commented May 8, 2017

@dhensby sorry, mistyped. I mean master :S

@dhensby dhensby changed the base branch from 2.5 to master May 8, 2017 12:32
@dhensby
Copy link
Contributor Author

dhensby commented May 8, 2017

Done - though from a selfish point of view I'd love to see this patch make the next 2.5.x release 👼

@Ocramius
Copy link
Member

Ocramius commented May 8, 2017

@dhensby we'll likely get it there, it's just how we do it around here though: master first, backports after evaluation ;-)

@dhensby
Copy link
Contributor Author

dhensby commented May 8, 2017

awesome - thanks.

@Ocramius
Copy link
Member

Ocramius commented May 8, 2017

Restarted crashed build tasks

@Ocramius Ocramius requested a review from deeky666 May 8, 2017 14:58
@Ocramius Ocramius added this to the 2.5.13 milestone May 8, 2017
@deeky666 deeky666 merged commit c48effb into doctrine:master May 10, 2017
@deeky666
Copy link
Member

@dhensby thanks!

@deeky666
Copy link
Member

Backported to 2.5 via c8ea13a and 9362698

@deeky666 deeky666 self-assigned this May 10, 2017
@dhensby dhensby deleted the pulls/fix-2714 branch May 10, 2017 16:42
@dhensby
Copy link
Contributor Author

dhensby commented May 10, 2017

Thanks @deeky666 @Ocramius

@Ocramius Ocramius changed the title FIX Sequence::isAutoIncrementsFor now case insensitive #2714 Sequence::isAutoIncrementsFor() is now case-insensitive Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deeky666 deeky666 deeky666 approved these changes

Assignees

@deeky666 deeky666

Labels
Bug Schema Definition Schema Introspection Sequences
Projects
None yet
Milestone
2.5.13
Development

Successfully merging this pull request may close these issues.
3 participants
@dhensby @Ocramius @deeky666