Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#889 On OracleDB, primary key is considered missing if index_name != constraint_name #2686

Merged
merged 2 commits into from
May 20, 2017
Merged

#889 On OracleDB, primary key is considered missing if index_name != constraint_name #2686

merged 2 commits into from
May 20, 2017

Conversation

marius-meissner
Copy link
Contributor

@marius-meissner marius-meissner commented Mar 23, 2017 •
edited
Loading

Same as pull request #889, but with added test.
Fixes issue #1234 and doctrine/orm#6206

@Ocramius Ocramius added this to the 2.5.13 milestone Mar 23, 2017
deeky666
deeky666 previously requested changes May 10, 2017
View reviewed changes
tests/Doctrine/Tests/DBAL/Functional/Schema/OracleSchemaManagerTest.php Outdated
{
$table = new Table('list_table_indexes_pk_id_test');
$table->setSchemaConfig($this->_sm->createSchemaConfig());
$table->addColumn('id', 'integer', ['notnull' => true]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use short array syntax here, as we target this patch for 2.5 where we still support PHP 5.3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeky666 let's fix it ourselves during backport

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeky666: Thank you for the hint. I just replaced all shorthand array syntax.

@Ocramius Ocramius assigned Ocramius and unassigned deeky666 May 20, 2017
@Ocramius Ocramius dismissed deeky666’s stale review May 20, 2017 13:30

CS concerns handled

@Ocramius
Copy link
Member

🚢 thanks @SkydiveMarius!

@Ocramius Ocramius modified the milestones: 2.6, 2.5.13 May 20, 2017
@Ocramius Ocramius merged commit 51220fc into doctrine:master May 20, 2017
Ocramius added a commit that referenced this pull request May 20, 2017
@Ocramius
Merge branch 'fix/#2686-#889-fix-oracle-check-for-constraint-and-inde…
76b65d7 
…x-name-equality' into 2.5

Close #2686
Close #889
@Ocramius
Copy link
Member

Backported to 2.5 via 76b65d7

This was referenced May 20, 2017
Closed
Closed
Closed
@Ocramius Ocramius changed the title Fixed oracle bug that primary key is missing if index_name != constraint_name On OracleDB, primary key is considered missing if index_name != constraint_name Jul 22, 2017
@Ocramius Ocramius changed the title On OracleDB, primary key is considered missing if index_name != constraint_name #889 On OracleDB, primary key is considered missing if index_name != constraint_name Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@deeky666 deeky666 deeky666 left review comments

Assignees

@Ocramius Ocramius

Labels
Bug Oracle Platforms Schema Management
Projects
None yet
Milestone
2.5.13
Development

Successfully merging this pull request may close these issues.
3 participants
@marius-meissner @Ocramius @deeky666