Merge 3.8.x up into 4.0.x #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it will just pull the latest one.
Specify the minor version number for MySQL image
In a recent PR, we got reports from CodeCov about several lines not being covered. After further inspection, I found an error message in the coverage file upload saying we hit a rate limit. This will make it more likely we spot such issues in the future. The PR: doctrine#6370
…odecov Set fail_ci_if_error flag to true
It is necessary for builds that run on branches that are not from a fork. Branches from a fork use the tokenless upload. See https://docs.codecov.com/docs/codecov-uploader#supporting-token-less-uploads-for-forks-of-open-source-repos-using-codecov
Provide CODECOV_TOKEN
| Q | A |------------- | ----------- | Type | bug | Fixed issues | #### Summary Fix invalid SQL generated when table with schema is given. As it was invalid, this PR is fully BC in sense of the exact generated SQL.
…octrine#6338) | Q | A |------------- | ----------- | Type | bug | Fixed issues | n/a #### Summary Fix doctrine#5617, `''` was changed to `'main'`, but one occurence was missed.
|
@greg0ire I can fork your branch and look at it today evening. |
| Q | A |------------- | ----------- | Type | bug | Fixed issues | doctrine#4283 #### Summary https://learn.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-addextendedproperty-transact-sql?view=sql-server-ver15 shows the `sp_addextendedproperty` accepts `sysname` datatype which is subtype of string datatype and therefore the values must be escaped as string literal instead of escaped identifier. This is evident also in the [examples](https://learn.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-addextendedproperty-transact-sql?view=sql-server-ver15#examples). As the DBAL method arguments accepts possibly escaped identifier, we unescape it before we escape the argument as string literal.
Bump workflow actions
|
Here is greg0ire#7 PR to your branch with the fixes. |
Fix 3.8 -> 4.0 merge
Psalm complains about this because it cannot understand this for now, and I don't think this is a reasonable feature request to do. Instead of baselining this, let's switch to another implementation, that might be easier to understand anyway.
Setup dependabot
|
This URL seems to be having issues: https://public.dhe.ibm.com/ibmdl/export/pub/software/data/db2/drivers/odbc_cli/linuxx64_odbc_cli.tar.gz
Not sure that will work 😛 |
SenseException
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.