[Need Help] Testing boolean comparison using ParameterType

[nickvergessen]

Q	A
Type	bug
Fixed issues	To-Be-Raised-If-Needed

Summary

In Nextcloud we started to experience strange behaviour with Oracle when using boolean FALSE in WHERE-clauses with parameters.
The behaviour works as expected, when as parameter type we pass Doctrine\DBAL\Types\Types::BOOLEAN instead of Doctrine\DBAL\ParameterType::BOOLEAN in our code base, but I think from the doc blocks and declarations this is not what should be done.

This fix can also not be confirmed here using the 4.1.x branch as a base, but my test at least is failing with the same problem/bug: Using false in a where condition seems to not be possible?

• passing false => https://github.com/doctrine/dbal/actions/runs/12902066473/job/35975109513?pr=6526#step:6:75
• passing 0 => https://github.com/doctrine/dbal/actions/runs/11011277241/job/30575035189?pr=6526#step:6:73

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[nickvergessen]

I still need help on this 🫠

[nickvergessen]

@morozov @greg0ire could one of you maybe help me with this?

[morozov]

@nickvergessen I don't understand what problem you are trying to solve. The tests you added look correct at a glance and all pass in my local setup on Oracle. The CI logs you're referring to are expired. Could you force-push your branch to have the CI run them again?

[nickvergessen]

I don't understand what problem you are trying to solve.

When you have a where condition with a columnA = false kind of check, the condition is not working correctly on PDO Oracle in our tests.

OCI8 passes

• Oracle 23 https://github.com/doctrine/dbal/actions/runs/12902118298/job/35975242757?pr=6526#step:6:71
• Oracle 18 https://github.com/doctrine/dbal/actions/runs/12902118298/job/35975240855?pr=6526#step:6:71

OK, but there were issues!
Tests: 3241, Assertions: 4573, Skipped: 566, Incomplete: 5.

PDO Oracle fails

• Oracle 23 https://github.com/doctrine/dbal/actions/runs/12902118298/job/35975243108?pr=6526#step:6:73
• Oracle 18 https://github.com/doctrine/dbal/actions/runs/12902118298/job/35975241188?pr=6526#step:6:73

There were 2 failures:

1) Doctrine\DBAL\Tests\Functional\Query\QueryBuilderBoolTest::testDeleteBooleanFalse
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 1
+    0 => '1'
+    1 => '2'
 )

/home/runner/work/dbal/dbal/tests/Functional/Query/QueryBuilderBoolTest.php:94

2) Doctrine\DBAL\Tests\Functional\Query\QueryBuilderBoolTest::testDeleteBooleanFalseWithWrongType
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 1
+    0 => '1'
+    1 => '2'
 )

/home/runner/work/dbal/dbal/tests/Functional/Query/QueryBuilderBoolTest.php:114

FAILURES!
Tests: 3233, Assertions: 4497, Failures: 2, Skipped: 594, Incomplete: 5.

[morozov]

This is probably due to the bug in PDO_OCI (php/php-src#15182). I reopened it as php/pecl-database-pdo_oci#12.

[nickvergessen]

Thanks for checking, I guess there is not a lot we can do then atm.
Would you want to merge the PR afterwards (or now with skipping it on PDO?)