fix: quote namespace names

[nikophil]

Follow up of this discussion

ping @morozov

[nikophil]

at first, I was thinking of create an asset Doctrine\DBAL\Schema\Namespace but namespace are handled in a different way than other assets, and it seemed easier to do it like this, but I still can create the new class

[morozov]

Even though it's not consistently documented, all get[...]SQL() methods of this class accept SQL fragments as string parameters and just concatenate them with other fragments of SQL. Treating the schema name as a literal is against this implied contract. It's the caller of the method who should quote the names that need to be quoted.

Depending on how you manage your schema via DBAL, you may try explicitly quoting names in the schema definition similar to this:

dbal/tests/Functional/Schema/OracleSchemaManagerTest.php

Lines 251 to 255 in 95d093a

	public function testQuotedTableNameRemainsQuotedInSchema(): void
	{
	$table = new Table('"tester"');
	$table->addColumn('"id"', Types::INTEGER);
	$table->addColumn('"name"', Types::STRING, ['length' => 32]);

This won't be necessary in DBAL 5.0 (see #6589).

[morozov]

Within the current API, a proper solution would be to assume all object names obtained by introspecting the database quoted, but schema names are returned as strings, so there's no way to indicate that besides wrapping all names in quotes. Doing that will fix this bug but will be a breaking change, so we can do that only in a major release.

[nikophil]

hi @morozov

it's not really clear to me what to do to fix this? are our hands tied and this whole stuff (and handling postgresql schema in dbal) cannot be fixed before v5?

[morozov]

As for fixing this issue, yes. But my understanding is that you want to fix a test failure that prevents the #6576 from succeeding. I believe this issue needs to be addressed in the test suite, not in the code. For instance, you may improve isolation of the tests so that the lack of proper handling of schema names that need to be quoted doesn't affect the tests that don't use such names.