Deprecate silencing transaction-related errors #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
deprecate-silencing
branch
from
6d23827 to
d53a6ef
Compare
Some platforms do not support transactions for DDL statements, and doctrine/migrations historically swipes the issue under the rug by not letting uninformed users know about it. Since PHP 8, we even silence the issue suddenly made visible by PDO. Let's stop doing that. MySQL users should typically set transactional to false in their configuration and manually edit the isTransactional method override generated in their migrations to return true (or drop it entirely) if they run DDL migrations and want those to be transactional.
greg0ire
force-pushed
the
deprecate-silencing
branch
from
d53a6ef to
38c7f52
Compare
goetas
reviewed
Jun 19, 2021
| @@ -15,6 +16,18 @@ final class TransactionHelper | |||
| public static function commitIfInTransaction(Connection $connection): void | |||
| { | |||
| if (! self::inTransaction($connection)) { | |||
| Deprecation::trigger( | |||
There was a problem hiding this comment.
it would be nice to know which migration triggered the error... but i guess that here there is not enough context to know that... :(
goetas
approved these changes
Jun 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some platforms do not support transactions for DDL statements, and
doctrine/migrations historically swipes the issue under the rug by not
letting uninformed users know about it. Since PHP 8, we even silence the
issue suddenly made visible by PDO. Let's stop doing that.
MySQL users should typically set transactional to false in their
configuration and manually edit the isTransactional method override
generated in their migrations to return true (or drop it entirely) if
they run DDL migrations and want those to be transactional.