DiffGenerator: fix removing schema from table name before applying regex filtering #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristi-contiu
force-pushed
the
issue-1487
branch
from
054f084 to
41cb96c
Compare
cristi-contiu
changed the title
cristi-contiu
force-pushed
the
issue-1487
branch
3 times, most recently
from
4ab7e80 to
a938f5f
Compare
cristi-contiu
force-pushed
the
issue-1487
branch
from
0cb8736 to
a76ce4d
Compare
cristi-contiu
changed the title
cristi-contiu
changed the title
greg0ire
reviewed
Feb 28, 2025
| if ($this->platform->supportsSchemas()) { | ||
| return $name; | ||
| } | ||
|
|
There was a problem hiding this comment.
After your change, I don't think the phpdoc comment is accurate anymore. Also, if the platform does not support schémas, surely the dot in a name should be interpreted literally? So... this method is no longer needed maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Failing test and suggested fix for #1487, requested in #1490 (review)
There are differences in the way Migrations and DBAL apply the
SchemaAssetsFilter, usually regex: DBAL applies it on the table name (which can be qualified or unqualified, depending on platform schema support and if the table is in the default search-path schema) while Migrations always removes the schema and only applies the filter on the unqualified table name (my_table).This fix applies the
SchemaAssetsFilteron the table name exactly as provided by the DBAL for platforms that support schema.