Fix build for DBAL 4 #10354
Merged
Fix build for DBAL 4 #10354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Dec 30, 2022
| @@ -1044,7 +1046,7 @@ protected function getHydrationCacheId(): array | |||
| ksort($hints); | |||
| assert($queryCacheProfile !== null); | |||
|
|
|||
| return $queryCacheProfile->generateCacheKeys($sql, $parameters, $hints); | |||
| return $queryCacheProfile->generateCacheKeys($sql, $parameters, $types, $hints); | |||
There was a problem hiding this comment.
This is actually an interesting find. We've called this method the wrong way the whole time. 🫣
derrabus
force-pushed
the
bugfix/dbal-4-array-parameter-type
branch
from
0a6de30 to
a39ecaf
Compare
derrabus
force-pushed
the
bugfix/dbal-4-array-parameter-type
branch
from
a39ecaf to
a30b644
Compare
greg0ire
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build after the changes of doctrine/dbal#5839.