Address quoteIdentifier() deprecation

[greg0ire]

We should be using quoteSingleIdentifier(), assuming we only ever pass single identifiers here.

See doctrine/dbal#6590

[greg0ire]

The tests pass, but I'm not sure if e.g. $tableName really is always going to be a single identifier here, and what to do if it isn't. That being said, if quoted is set, then… maybe we should treat everything as a single identifier?

[morozov]

To preserve the existing behavior, table names should be split into schema name and unqualified name and quoted individually (basically, what quoteIdentifier() would do). Even if the identifier is quoted (e.g. "inventory.products"), AbstractAsset::_setName() in DBAL 4 would parse it and consider inventory to be the schema name.

I guess it's better to add or find an existing test that covers this case (e.g. create a schema in Postgres and and use a qualified table name on an entity).

[greg0ire]

After attempting what you suggested, I now believe that name will never contain the schema part, which means such a test cannot be written.

[morozov]

I came to the opposite conclusion in #11812 (comment). But maybe we're talking about the same thing.

My understanding is that if the name contains a dot, the part before the dot will be considered the schema name.

In any event, quoting all values as "single identifier" looks right to me.