Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document BC-break due to type declaration #7170

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Document BC-break due to type declaration #7170

merged 1 commit into from
Apr 3, 2018

Conversation

lcobucci
Copy link
Member

@lcobucci lcobucci commented Apr 3, 2018

I forgot to add this in #7092, so here it goes.

@lcobucci
Document BC-break due to type declaration
1f0660d 
Identifier generators and value generation plan are now using type
declaration as much as possible.
@lcobucci lcobucci added this to the 3.0 milestone Apr 3, 2018
@lcobucci lcobucci requested review from Majkl578 and Ocramius April 3, 2018 08:35
@Ocramius Ocramius self-assigned this Apr 3, 2018
Ocramius
Ocramius approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 6fb6b9d into doctrine:master Apr 3, 2018
@lcobucci lcobucci deleted the document-bc-break-due-to-return-type-declaration branch April 3, 2018 09:24
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@Majkl578 Majkl578 Awaiting requested review from Majkl578

Assignees

@Ocramius Ocramius

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcobucci @Ocramius @greg0ire